🛡️ Sentinel: [MEDIUM] Fix information disclosure in auth decorator - #17
Conversation
Log authentication exceptions internally instead of exposing exception details (str(e)) in the HTTP 401 JSON response payload to callers. Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: MEDIUM
💡 Vulnerability: Information disclosure in login_required decorator via error details
🎯 Impact: Unauthenticated clients receiving authentication errors could view internal exception details (e.g. database connection strings, credentials, or internal error messages).
🔧 Fix: Log exceptions internally with logger.warning and return a generic {'error': 'Unauthorized'} JSON response without leaking internal details.
✅ Verification: Unit test in tests/test_auth_security.py verifies that internal exception messages are omitted from HTTP responses. Full test suite and pylint linter pass.
PR created automatically by Jules for task 12714871037264957558 started by @Pmaster-dev